3.3.0 failing to build

[mohd-akram]

It fails to build on some systems:

/opt/local/var/macports/build/mimalloc-5f885923/work/mimalloc-3.3.0/src/alloc-override.c:99:21: error: call to undeclared library function 'aligned_alloc' with type 'void *(unsigned long, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    MI_INTERPOSE_MI(aligned_alloc),
                    ^
/opt/local/var/macports/build/mimalloc-5f885923/work/mimalloc-3.3.0/src/alloc-override.c:99:21: note: include the header <stdlib.h> or explicitly provide a declaration for 'aligned_alloc'
1 error generated.

Also, I'm not sure if it's supposed to enter that block on older systems (in this case 10.12). Full log here.

[daanx]

Ah, that is strange, the code looks like:

  MI_INTERPOSE_DECLS(_mi_interposes_10_15) __OSX_AVAILABLE(10.15) = {
    MI_INTERPOSE_MI(aligned_alloc),
  };

so it is already checking for version 10.15 right? Maybe the attribute for available is not yet working in 10.12 ?
If it is not too difficult, can you try replacing the above with an explicit test as:

#if defined(MAC_OS_X_VERSION_10_15) && (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_15)
  MI_INTERPOSE_DECLS(_mi_interposes_10_15) = {
    MI_INTERPOSE_MI(aligned_alloc),
  };
#endif

Maybe we need this anyway as the __OSX_AVAILABLE(10.15) only sets the available attribute but perhaps the compiler still tries to resolve the aligned_alloc...

[mohd-akram]

Yeah, that patch worked :) Thanks

Maybe we need this anyway as the __OSX_AVAILABLE(10.15) only sets the available attribute but perhaps the compiler still tries to resolve the aligned_alloc...

That seemed to be the case.

[mohd-akram]

The build fails on macOS 10.6 i386 for a different reason:

Undefined symbols for architecture i386:
  "_mi_prim_tls_slot", referenced from:
      _malloc in alloc.c.o
      _mi_malloc in alloc.c.o
      _mi_calloc in alloc.c.o
      _realloc in alloc.c.o
      _mi_realloc in alloc.c.o
      _strdup in alloc.c.o
      _mi_strdup in alloc.c.o
      ...
  "_mi_prim_tls_slot_set", referenced from:
      __mi_theap_cached_set in init.c.o
      __mi_theap_default_set in init.c.o
ld: symbol(s) not found for architecture i386

I see i386 is missing here. Is it meant to be supported?

EDIT: It also looks like there was a check to stop the compilation from proceeding, but was removed in a7f84f3:

#if MI_TLS_SLOT
# if !defined(MI_HAS_TLS_SLOT)
#  error "trying to use a TLS slot for the default theap, but the mi_prim_tls_slot primitives are not defined"
# endif

[daanx]

I pushed a potential fix where we fall back to use pthreads instead. Let me know how it goes :-)

[mohd-akram]

@daanx That worked, thanks!