Skip to content

fix: Fix the issues of raise exception#5130

Open
wangliang181230 wants to merge 14 commits into1Panel-dev:v2from
wangliang181230:PR/fix-throw-exception
Open

fix: Fix the issues of raise exception#5130
wangliang181230 wants to merge 14 commits into1Panel-dev:v2from
wangliang181230:PR/fix-throw-exception

Conversation

@wangliang181230
Copy link
Copy Markdown
Contributor

@wangliang181230 wangliang181230 commented Apr 21, 2026

What this PR does / why we need it?

fix: Fix the issue of raise exception

Summary of your change

修复 抛出异常 相关的问题

判断器中,不为空 判断出现异常的截图:
图片

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 21, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

for (let index = 0; index < branch_condition_list.length; index++) {
const element = branch_condition_list[index]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix style

@wangliang181230 wangliang181230 changed the title fix: Fix the keyword for raise exception fix: Fix the issue of raise exception Apr 21, 2026
raise AppApiException(500, _('Application does not exist'))
if not application.file_upload_enable:
return AppApiException(500, _('File upload is not enabled'))
raise AppApiException(500, _('File upload is not enabled'))
Copy link
Copy Markdown
Contributor Author

@wangliang181230 wangliang181230 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关键字错误,这个方法并不是一个返回异常对象的方法。

@wangliang181230 wangliang181230 changed the title fix: Fix the issue of raise exception fix: Fix the issues of raise exception Apr 21, 2026
try:
return source_value is not None and len(source_value) > 0
except Exception:
return True
Copy link
Copy Markdown
Contributor Author

@wangliang181230 wangliang181230 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len(source_value) 可能会抛出异常,捕获处理。
因为抛出异常时 source_value is not None 已经判定为 True,表示对象不为空,所以len方法出现异常后,直接 return True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant