fix(ai-client): add @standard-schema/spec to devDependencies#428
fix(ai-client): add @standard-schema/spec to devDependencies#428AlemTuzlak merged 6 commits intomainfrom
Conversation
Without this package installed, all types that depend on StandardJSONSchemaV1 silently degrade to any. Moving from devDependencies to dependencies ensures consumers get it transitively. Fixes #235
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Changeset Version Preview10 package(s) bumped directly, 23 bumped as dependents. 🟥 Major bumps
🟩 Patch bumps
|
|
View your CI Pipeline Execution ↗ for commit c8fa782
☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-anthropic
@tanstack/ai-client
@tanstack/ai-code-mode
@tanstack/ai-code-mode-skills
@tanstack/ai-devtools-core
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-groq
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-openrouter
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
…ependency # Conflicts: # packages/typescript/ai/package.json # pnpm-lock.yaml
It's not imported directly in ai-client's source, but is needed at build time so TypeScript can resolve the forward references to `StandardJSONSchemaV1` that live inside `InferToolInput` / `InferToolOutput` (both imported from @tanstack/ai and re-used in ai-client's public .d.ts surface). Knip's static import graph can't see that, so whitelist the dep here.
Summary
Adds
@standard-schema/specto@tanstack/ai-client'sdevDependenciesso TypeScript can follow through theInferToolInput/InferToolOutputchain at build time. Types-only dep — zero runtime cost.Without it,
@tanstack/ai-client's published.d.tsfiles reference types from@tanstack/aithat depend onStandardJSONSchemaV1, and the resolution silently degrades toany/unknownat the consumer site. That's what causestoolDefinition(...).client((input) => ...)to showinput: unknownin user code.Kept as a devDep intentionally — it's only needed during
@tanstack/ai-client's own type checking / build, not shipped at runtime.Fixes #235
Test plan
pnpm test:typeson@tanstack/aiand@tanstack/ai-clientpnpm test:libon both (198 tests on ai-client)Summary by CodeRabbit
Bug Fixes
unknown.Chores
Release