chore: upgrade to solid v2 beta 7 by brenelz · Pull Request #10516 · TanStack/query

brenelz · 2026-04-19T00:27:53Z

No description provided.

coderabbitai · 2026-04-19T00:28:00Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 34e5c9a9-3bd7-4f3c-9120-38a078d95fde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-19T00:28:20Z

View your CI Pipeline Execution ↗ for commit 6788069

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 14s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-19 03:27:26 UTC

pkg-pr-new · 2026-04-19T00:33:38Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10516

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10516

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10516

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10516

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10516

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10516

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10516

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10516

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10516

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10516

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10516

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10516

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10516

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10516

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10516

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10516

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10516

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10516

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10516

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10516

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10516

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10516

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10516

commit: 6788069

nidhishgajjar · 2026-04-19T00:57:26Z

Summary

This PR upgrades Solid.js dependencies from v2.0.0-beta.4/5 to v2.0.0-beta.7 and vite-plugin-solid from 3.0.0-next.4 to 3.0.0-next.5 across all Solid-related packages and examples. The primary code changes adapt to Solid v2's stricter ownership model and auto-disposal behavior for memos, requiring use of createSignal(fn) instead of createMemo in certain contexts and wrapping store writes with runWithOwner(null, ...) to escape owned scopes.

Architecture

The changes affect the Solid query integration layer across:

packages/solid-query/src/useBaseQuery.ts - Core query hook implementation
packages/solid-query/src/useIsFetching.ts - Fetching status tracking
packages/solid-query/src/useIsMutating.ts - Mutation status tracking
packages/solid-query/src/useMutationState.ts - Mutation state management
packages/solid-query/src/useQueries.ts - Multiple query management

The changes adapt to Solid v2's ownership model where:

Memos that aren't reactively read get auto-disposed, cascading to cleanup handlers
Signal/store writes within owned scopes throw errors
Signal option naming changed from pureWrite to ownedWrite

Issues

[warning] packages/solid-query/src/useBaseQuery.ts:155-160 — The change from createMemo to createSignal for client, defaultedOptions, and trackedDefaultedOptions is semantically different. createMemo caches values and only recomputes when dependencies change, while createSignal(fn) with a function will create a new signal on each access. This could cause unnecessary recomputation or loss of memoization benefits. Verify this doesn't impact performance negatively by adding benchmarking or profiling.

[warning] packages/solid-query/src/useBaseQuery.ts:241-289 — The queryResource restructuring removes the ssrSource: 'client' option from the resource creation. This option was previously passed to createMemo. Ensure SSR behavior is preserved without this option, particularly for streaming scenarios. Add explicit SSR tests to verify hydration still works correctly.

[warning] packages/solid-query/src/useBaseQuery.ts:253-260 — The error handling logic is restructured. Previously, reject was called outside of runWithOwner, now it's potentially inside or removed. Verify error propagation still works correctly, especially for thrown errors during SSR. The early return after reject in the new code could skip important cleanup.

[warning] packages/solid-query/src/useBaseQuery.ts:195-202 — The observer.setOptions call is now wrapped in runWithOwner(null, ...). While this prevents throwing, it means the observer update happens outside the component's ownership scope. This could affect tracking and cleanup if the observer relies on owner context. Verify observer lifecycle management remains correct.

[suggestion] packages/solid-query/src/useBaseQuery.ts:155-160 — Consider adding comments explaining why createSignal(fn) is used instead of createMemo, referencing the specific Solid v2 behavior that necessitates this change. The current comment is good but could reference Solid v2 documentation or issues for future maintainers.

[suggestion] packages/solid-query/src/useQueries.ts:248-268 — Similar runWithOwner usage as useBaseQuery. Ensure the batched updates in subscribeToObserver still work correctly when executed outside the owner scope. The queueMicrotask pattern has been removed - verify this doesn't cause timing issues with multiple rapid updates.

[suggestion] All changed files — The PR changes significant core logic but doesn't show corresponding test updates. Ensure comprehensive tests cover:

SSR hydration scenarios
Error handling and propagation
Query lifecycle (mount, update, unmount)
Multiple rapid option changes
Streaming with deferStream option
Cleanup on unmount during loading state

[suggestion] packages/solid-query/src/useBaseQuery.ts:290 — The comment about NotReadyError and Loading boundary has been simplified. Consider preserving more context about why the try-catch was needed and whether the new implementation handles the same edge cases.

Cross-file impact

Examples: All Solid examples updated to use beta.7 - users testing with these examples will need Solid v2 beta installed
pnpm-lock.yaml: Massive lockfile update - all consumers will get the new dependency versions
Type compatibility: The peer dependency in packages/solid-query/package.json shows ">=2.0.0-beta.0 <3.0.0" which is correct for supporting v2 betas
Backward compatibility: These changes break Solid v1.x compatibility due to the runWithOwner API and ownedWrite option. Ensure this is intentional and documented in migration guide

Assessment

request-changes — The changes appear technically sound for adapting to Solid v2's ownership model, but require verification that performance characteristics aren't degraded by replacing createMemo with createSignal, and that SSR/error handling behavior is preserved. Missing test coverage for the significant refactoring is concerning.

Automated review by code-review-agent. May contain mistakes. Ignore or rebut as you see fit.

chore: upgrade to solid v2 beta 7

2a7f100

github-actions bot added package: solid-query package: solid-query-persist-client package: solid-query-devtools labels Apr 19, 2026

ci: apply automated fixes

9d83d2e

chore: update vite-plugin-solid

5a51cc4

brenelz marked this pull request as draft April 19, 2026 01:34

brenelz added 2 commits April 18, 2026 22:06

fix: for ssr in tanstack start

1db75a5

fix: ssr fix

6788069

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: upgrade to solid v2 beta 7#10516

chore: upgrade to solid v2 beta 7#10516
brenelz wants to merge 5 commits intoTanStack:solid-query-v6-prefrom
brenelz:upgrade-to-solid-beta-7

brenelz commented Apr 19, 2026

Uh oh!

coderabbitai bot commented Apr 19, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Apr 19, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 19, 2026 •

edited

Loading

Uh oh!

nidhishgajjar commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

brenelz commented Apr 19, 2026

Uh oh!

coderabbitai bot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nidhishgajjar commented Apr 19, 2026

Summary

Architecture

Issues

Cross-file impact

Assessment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Apr 19, 2026 •

edited

Loading

nx-cloud bot commented Apr 19, 2026 •

edited

Loading

pkg-pr-new bot commented Apr 19, 2026 •

edited

Loading