feat: add DEBUG-level logs for SPI extension loading in ExtensionLoader#16231
Open
uuuyuqi wants to merge 1 commit intoapache:3.3from
Open
feat: add DEBUG-level logs for SPI extension loading in ExtensionLoader#16231uuuyuqi wants to merge 1 commit intoapache:3.3from
uuuyuqi wants to merge 1 commit intoapache:3.3from
Conversation
🤖 Generated with [Qoder][https://qoder.com] Change-Id: I9775997a1233f13a1faead1391ee01b743796c6d Co-developed-by: Qoder CLI <noreply@qoder.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16231 +/- ##
============================================
- Coverage 60.79% 60.78% -0.01%
- Complexity 11751 11769 +18
============================================
Files 1953 1953
Lines 89119 89164 +45
Branches 13444 13454 +10
============================================
+ Hits 54179 54199 +20
- Misses 29369 29389 +20
- Partials 5571 5576 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Add DEBUG-level observability to
ExtensionLoaderfor diagnosing SPI extension loading issues without external tools.Motivation: In environments with many internal SPI extensions across different versions, along with custom class-isolation frameworks, dependency conflicts or misconfiguration can cause extensions to be silently skipped or loaded with unexpected wrapper chains. Currently the only way to observe this is via Arthas or remote debugging, which has high operational cost. With these DEBUG logs, users can simply enable DEBUG level for
org.apache.dubbo.common.extension.ExtensionLoaderto get full visibility into the SPI loading process.Changes:
@Activate(onClass=...)dependencies, with the specific missing class namesloadClassIfActivetofindMissingOnClassto return missing class names for diagnostic outputAll logs are guarded by
isDebugEnabled(), no performance impact in production.Fixes #16230
Checklist