Open
Conversation
Contributor
|
@riasvdv this looks good to me! I don't see anything in here related to the build process. I'm assuming you didn't mess with that for the moment? |
at least as well as it was working before
# Conflicts: # resources/build/AppLayout.js # resources/build/SettingsGeneralPage.js # resources/build/_plugin-vue_export-helper.js
riasvdv
force-pushed
the
feature/legacy-assets
branch
from
d94e6b9 to
a4fe34c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ports a minimal implementation of asset bundles to make them work, so we have the ability to extract the yii2-adapter when the time comes while still being able to rely on the legacy frontend assets.
To get rid of the legacy AssetManager dependency, this also ports the Rebrand functionality to GeneralConfig instead of relying on an arbitrary folder