Skip to content

SessionFs structured error contract + workspace E2E tests #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveSandersonMS wants to merge 10 commits into
base: main
Choose a base branch
from
Open

SessionFs structured error contract + workspace E2E tests #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b39f0de
Update sessionFs types for structured error contract and add workspac…
SteveSandersonMS Apr 17, 2026
569aa34
Fix codegen: deduplicate $ ef siblings and $defs aliases
SteveSandersonMS Apr 20, 2026
1d46315
Codegen updates and fixes
SteveSandersonMS Apr 20, 2026
c6e97d4
Fix nullable result types in all 4 SDK codegens
SteveSandersonMS Apr 20, 2026
2209a43
More codegen fixes
SteveSandersonMS Apr 20, 2026
507f2da
So many more codegen fixes
SteveSandersonMS Apr 20, 2026
9b8a314
Logging for C# e2e tests
SteveSandersonMS Apr 20, 2026
240ceda
Fix C# SessionFs tests
SteveSandersonMS Apr 20, 2026
24a4b71
Add idiomatic SessionFsProvider abstractions for all 4 SDK languages
SteveSandersonMS Apr 20, 2026
01d231c
fix: Python JSON-RPC dispatch sends null for void results
SteveSandersonMS Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dotnet/src/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using StreamJsonRpc;
using StreamJsonRpc.Protocol;
using System.Collections.Concurrent;
using System.Data;
using System.Diagnostics;
Expand Down Expand Up @@ -1104,7 +1105,7 @@ await Rpc.SessionFs.SetProviderAsync(
cancellationToken);
}

private void ConfigureSessionFsHandlers(CopilotSession session, Func<CopilotSession, ISessionFsHandler>? createSessionFsHandler)
private void ConfigureSessionFsHandlers(CopilotSession session, Func<CopilotSession, SessionFsProvider>? createSessionFsHandler)
{
if (_options.SessionFs is null)
{
Expand Down Expand Up @@ -1836,6 +1837,7 @@ private static LogLevel MapLevel(TraceEventType eventType)
AllowOutOfOrderMetadataProperties = true,
NumberHandling = JsonNumberHandling.AllowReadingFromString,
DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull)]
[JsonSerializable(typeof(CommonErrorData))]
[JsonSerializable(typeof(CreateSessionRequest))]
[JsonSerializable(typeof(CreateSessionResponse))]
[JsonSerializable(typeof(CustomAgentConfig))]
Expand Down
178 changes: 157 additions & 21 deletions dotnet/src/Generated/Rpc.cs
View file
Open in desktop

Large diffs are not rendered by default.

106 changes: 104 additions & 2 deletions dotnet/src/Generated/SessionEvents.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dotnet/src/Session.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,15 +607,15 @@ private async Task ExecutePermissionAndRespondAsync(string requestId, Permission
{
return;
}
await Rpc.Permissions.HandlePendingPermissionRequestAsync(requestId, result);
await Rpc.Permissions.HandlePendingPermissionRequestAsync(requestId, new PermissionDecision { Kind = result.Kind.Value });
}
catch (Exception)
{
try
{
await Rpc.Permissions.HandlePendingPermissionRequestAsync(requestId, new PermissionRequestResult
await Rpc.Permissions.HandlePendingPermissionRequestAsync(requestId, new PermissionDecision
{
Kind = PermissionRequestResultKind.DeniedCouldNotRequestFromUser
Kind = PermissionRequestResultKind.DeniedCouldNotRequestFromUser.Value
});
}
catch (IOException)
Expand Down
Loading
Loading