feat(animations): set smother animations for modal in ionic#31082
feat(animations): set smother animations for modal in ionic#31082os-davidlourenco wants to merge 7 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-davidlourenco
added
package: core
github-actions
bot
removed
package: angular
os-davidlourenco
force-pushed
the
ROU-12702
branch
from
9c1160c to
e403a3a
Compare
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Most of the animations are duplicates of md. Please remove those and continue to md as the default. However, the Jira ticket is for modal only. If animations differ from md then please open a new PR for those.
There was a problem hiding this comment.
Why are these snapshots being updated? Nothing changed in the animations or the test.
There was a problem hiding this comment.
Honestly, I don't know, they were updated after ran the pipeline
There was a problem hiding this comment.
When I open the modal on the basic page, there's a flicker on the content. Please fix that.
Screen.Recording.2026-04-20.at.3.14.54.PM.mov
There was a problem hiding this comment.
This flicker is not happening due to the change that I made, and was already present. The main reason for this behavior is the style that is injected in the test, and that is only applied after the animation has finished, resulting in this flicker.
4 participants
Issue number: resolves internal
What is the current behavior?
The animations are only defined for iOS and md, and the Ionic theme uses the md animations.
What is the new behavior?
New animation files for Ionic were added to each component that uses animations, based on the md file.
The new Ionic animation file for the modal includes changes to the transitions.
Changes in the gestures for the modal, only for the Ionic theme.
Does this introduce a breaking change?
Other information