Fix snapshot disk utilization classification for Firecracker#198
Merged
sjmiller609 merged 1 commit intomainfrom Apr 20, 2026
Merged
Fix snapshot disk utilization classification for Firecracker#198sjmiller609 merged 1 commit intomainfrom
sjmiller609 merged 1 commit intomainfrom
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies disk utilization and resource monitoring libraries, not kernel API endpoints or Temporal workflows as specified in the filter. To monitor this PR anyway, reply with |
hiroTamada
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory,memory.zst, ormemory.lz4memory-ranges*snapshot namesTesting
Note
Medium Risk
Changes snapshot classification logic that feeds disk utilization metrics, which could affect monitoring/alerting and capacity dashboards if misclassified. Scope is small and covered by updated unit/integration-style tests.
Overview
Updates snapshot disk utilization classification to recognize Firecracker standby snapshot layouts by treating
memory,memory.zst, andmemory.lz4as valid snapshot memory artifacts (alongside legacymemory-ranges*).Refreshes documentation and expands tests to cover the new Firecracker filenames, including monitoring’s cached disk-utilization metric emission.
Reviewed by Cursor Bugbot for commit e2795f6. Bugbot is set up for automated code reviews on this repo. Configure here.