Skip to content

Fix snapshot disk utilization classification for Firecracker#198

Merged
sjmiller609 merged 1 commit intomainfrom
codex/fix-snapshot-metric-labels
Apr 20, 2026
Merged

Fix snapshot disk utilization classification for Firecracker#198
sjmiller609 merged 1 commit intomainfrom
codex/fix-snapshot-metric-labels

Conversation

@sjmiller609
Copy link
Copy Markdown
Collaborator

@sjmiller609 sjmiller609 commented Apr 18, 2026

Summary

  • classify Firecracker standby snapshots that use memory, memory.zst, or memory.lz4
  • keep recognizing the legacy memory-ranges* snapshot names
  • update disk utilization and monitoring tests to cover the live Firecracker layout

Testing

  • go test ./lib/diskutilization
  • go test ./lib/resources -run TestStartMonitoringPublishesDiskUtilizationFromCachedSnapshot

Note

Medium Risk
Changes snapshot classification logic that feeds disk utilization metrics, which could affect monitoring/alerting and capacity dashboards if misclassified. Scope is small and covered by updated unit/integration-style tests.

Overview
Updates snapshot disk utilization classification to recognize Firecracker standby snapshot layouts by treating memory, memory.zst, and memory.lz4 as valid snapshot memory artifacts (alongside legacy memory-ranges*).

Refreshes documentation and expands tests to cover the new Firecracker filenames, including monitoring’s cached disk-utilization metric emission.

Reviewed by Cursor Bugbot for commit e2795f6. Bugbot is set up for automated code reviews on this repo. Configure here.

@sjmiller609 sjmiller609 requested a review from hiroTamada April 18, 2026 17:58
@sjmiller609 sjmiller609 marked this pull request as ready for review April 18, 2026 17:58
@firetiger-agent
Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: PR modifies disk utilization and resource monitoring libraries, not kernel API endpoints or Temporal workflows as specified in the filter.

To monitor this PR anyway, reply with @firetiger monitor this.

@sjmiller609 sjmiller609 merged commit 62ab3c8 into main Apr 20, 2026
10 of 14 checks passed
@sjmiller609 sjmiller609 deleted the codex/fix-snapshot-metric-labels branch April 20, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants