Skip to content

WIP: Alternative heat to get#2949

Open
aldas wants to merge 4 commits intolabstack:masterfrom
aldas:alternative_heat_to_get
Open

WIP: Alternative heat to get#2949
aldas wants to merge 4 commits intolabstack:masterfrom
aldas:alternative_heat_to_get

Conversation

@aldas
Copy link
Copy Markdown
Contributor

@aldas aldas commented Apr 19, 2026

Proposal for alternative solution to #2944 - do not register extra routes. use router internals to fallback from head to get. these extra IF checks do not register as meaningful change when running benchstat, but registering another route along with GET looks like a quick hack.

store benchmarks for this change

go test -run="-" -bench=".*" -count=8 ./... > benchmark_with_head.txt

check out current version

go test -run="-" -bench=".*" -count=8 ./... > benchmark_5_1_0.txt

and compare these two

benchstat benchmark_5_1_0.txt benchmark_with_head.txt 

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

❌ Patch coverage is 82.69231% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.09%. Comparing base (22e4b71) to head (49b5ca9).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
response.go 77.50% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
+ Coverage   93.07%   93.09%   +0.01%     
==========================================
  Files          43       43              
  Lines        4506     4545      +39     
==========================================
+ Hits         4194     4231      +37     
  Misses        195      195              
- Partials      117      119       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants