Skip to content

stream: ensuring cross-destruction in _duplexify to prevent leaks#62824

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
watilde:fixes-stream-dup
Apr 21, 2026
Merged

stream: ensuring cross-destruction in _duplexify to prevent leaks#62824
nodejs-github-bot merged 1 commit intonodejs:mainfrom
watilde:fixes-stream-dup

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Apr 19, 2026

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Apr 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (58a8e1d) to head (4d5d303).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62824      +/-   ##
==========================================
- Coverage   89.69%   89.69%   -0.01%     
==========================================
  Files         706      706              
  Lines      218222   218222              
  Branches    41768    41763       -5     
==========================================
- Hits       195731   195726       -5     
+ Misses      14411    14408       -3     
- Partials     8080     8088       +8     
Files with missing lines Coverage Δ
lib/internal/streams/duplexify.js 96.91% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

good spot

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2026
@nodejs-github-bot nodejs-github-bot merged commit dd85293 into nodejs:main Apr 21, 2026
76 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in dd85293

@watilde watilde deleted the fixes-stream-dup branch April 21, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants