Skip to content

http: reject addTrailers after finish #62832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
islandryu wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

http: reject addTrailers after finish #62832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,10 @@ function connectionCorkNT(conn) {
}

OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {
if (this.finished) {
throw new ERR_HTTP_HEADERS_SENT('set trailing');
}

this._trailer = '';
const keys = ObjectKeys(headers);
const isArray = ArrayIsArray(headers);
Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-http-outgoing-proto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,16 @@ assert.throws(() => {
message: 'Invalid character in trailer content ["404"]'
});

assert.throws(() => {
const outgoingMessage = new OutgoingMessage();
outgoingMessage.finished = true;
outgoingMessage.addTrailers({ 'x-foo': 'bar' });
}, {
code: 'ERR_HTTP_HEADERS_SENT',
name: 'Error',
message: 'Cannot set trailing headers after they are sent to the client'
});

{
const outgoingMessage = new OutgoingMessage();
assert.strictEqual(outgoingMessage.destroyed, false);
Expand Down
Loading