fix(round-robin-pool): use live clients length after TTL eviction#5070
Draft
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Draft
fix(round-robin-pool): use live clients length after TTL eviction#5070deepview-autofix wants to merge 1 commit intonodejs:mainfrom
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Conversation
The round-robin dispatcher loop captured `this[kClients].length` before iterating, but `kRemoveClient` can shrink the array during iteration when multiple clients are evicted by TTL. The stale length caused the modulus to point past the new array bounds, so `this[kClients][this[kIndex]]` returned `undefined` and the next property access (`.ttl` or `[kNeedDrain]`) threw a TypeError. Read the length dynamically on each iteration and bail out once the array is empty so the loop always indexes into valid entries. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ChALkeR
reviewed
Apr 19, 2026
Member
ChALkeR
left a comment
ChALkeR
left a comment
There was a problem hiding this comment.
pool logic still appears to be broken (both here and on main) and it just hangs in some conditions
will revisit later
Member
|
I don't think RoundRobinPool works at all, the problem seems to be deeper |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5070 +/- ##
==========================================
+ Coverage 93.09% 93.12% +0.02%
==========================================
Files 110 110
Lines 35788 35788
==========================================
+ Hits 33318 33326 +8
+ Misses 2470 2462 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The round-robin dispatcher loop captured
this[kClients].lengthbefore iterating, butkRemoveClientcan shrink the array during iteration when multiple clients are evicted by TTL. The stale length caused the modulus to point past the new array bounds, sothis[kClients][this[kIndex]]returnedundefinedand the next property access (.ttlor[kNeedDrain]) threw a TypeError.Read the length dynamically on each iteration and bail out once the array is empty so the loop always indexes into valid entries.