Draft
Conversation
4239a88 to
9afcf14
Compare
9afcf14 to
e70961f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uploading a seg
.ptwithmodel_type="yolov11"used to succeed silently then crash at inference. Same for rfdetr detect/seg mismatches. Adds two client-side checks:.pt↔model_typereconciliation inmodel_processor.process():checkpoint["model_name"](same field rf-detr's loader uses). Raises on conflict.model_type↔ project type cross-check inVersion.deploy().Also adds canonical
TASK_*constants toconfig.py.Test plan
python -m unittest— all passruff check roboflow— clean.pt+model_type="yolov11"on seg project → deploys asyolov11-seg, inference returns masks.pt+model_type="yolov11-pose"→ValueErrormodel_type="yolov11-seg"on detection project →ValueError.pt+model_type="yolov11"on detection project → clean deploy.pt+model_type="rfdetr-medium"→ValueErrormodel_type="rfdetr-seg-medium"on detection project →ValueError🤖 Generated with Claude Code