Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Automated test-gap detection for recent RustFS CLI changes. No user-facing bug report is linked.
Problem and user impact
The recent admin heal API alignment changed the RustFS admin endpoints used by heal status, start, and stop operations. Existing tests covered helper serialization and mapping, but they did not verify the actual HTTP request method, path, query string, or request body emitted by AdminClient.
Root cause
The request contract lived across small helpers plus AdminClient methods, so a future regression in method selection, encoded target construction, force-stop query parameters, or JSON body emission could pass the existing unit tests.
Solution
Add loopback HTTP tests for heal_status, heal_start, and heal_stop. The tests capture one signed admin request and assert the RustFS admin endpoint, method, query, and body shape.
Validation