Skip to content

feat(sql): add S3 Select command with probe and streaming support#145

Open
GatewayJ wants to merge 3 commits intorustfs:mainfrom
GatewayJ:main
Open

feat(sql): add S3 Select command with probe and streaming support#145
GatewayJ wants to merge 3 commits intorustfs:mainfrom
GatewayJ:main

Conversation

@GatewayJ
Copy link
Copy Markdown
Member

Related

  • Adds Phase-2 SQL capability discussed in local work branch.

Background

rc did not have a dedicated command for S3 Select queries on objects. Users had no direct CLI path to run SelectObjectContent across S3-compatible backends.

What Changed

  • Added new command: rc sql
  • Added core Select domain types and trait hooks:
    • SelectOptions, SelectInputFormat, SelectOutputFormat, SelectCompression
    • ObjectStore::probe_select_support
    • ObjectStore::select_object_content
  • Added S3 implementation for:
    • request mapping to AWS SDK SelectObjectContent
    • event-stream record forwarding to stdout writer
    • backend support probing and error classification
  • Wired command routing/help contract updates.

Validation

All required checks passed locally:

  • cargo fmt --all --check
  • cargo clippy --workspace -- -D warnings
  • cargo test --workspace

Notes

  • Rebasing conflicts were resolved against latest origin/main before publishing.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b10bb45607

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/s3/src/select.rs Outdated
Comment thread crates/s3/src/select.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant