Skip to content

feat: add ndarray/broadcast-scalar-like#11630

Merged
kgryte merged 8 commits intostdlib-js:developfrom
headlessNode:nd/brd-sclr-lke
Apr 20, 2026
Merged

feat: add ndarray/broadcast-scalar-like#11630
kgryte merged 8 commits intostdlib-js:developfrom
headlessNode:nd/brd-sclr-lke

Conversation

@headlessNode
Copy link
Copy Markdown
Member

@headlessNode headlessNode commented Apr 19, 2026

Resolves stdlib-js/metr-issue-tracker#277.

Description

What is the purpose of this pull request?

This pull request:

  • add ndarray/broadcast-scalar-like

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.

@stdlib-js/reviewers

@headlessNode headlessNode requested a review from a team April 19, 2026 20:31
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 19, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 19, 2026 •
edited
Loading

Coverage Report

No coverage information available.

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Apr 19, 2026
@headlessNode
Copy link
Copy Markdown
Member Author

headlessNode commented Apr 19, 2026

@kgryte Expected typescript CI error.

headlessNode
headlessNode commented Apr 19, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/docs/types/test.ts Outdated
@headlessNode
fix: apply suggestions from code review
0aedeba 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 20, 2026
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/benchmark/benchmark.js Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/benchmark/benchmark.js Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/docs/types/test.ts
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/lib/main.js Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/lib/main.js Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/lib/main.js Outdated
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/lib/main.js Outdated
kgryte
kgryte requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Apr 20, 2026
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 20, 2026
@headlessNode headlessNode requested a review from kgryte April 20, 2026 11:28
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 20, 2026
@kgryte
fix: add catch-all overload
04b6133 
Ensure that declarations don't start breaking if and when we add support for new data types and have yet to upgrade this package.

Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/docs/repl.txt Outdated
@kgryte
Apply suggestions from code review
5c415e1 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/broadcast-scalar-like/lib/main.js Outdated
@kgryte
Apply suggestions from code review
c741ed6 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 20, 2026

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte merged commit 82f105c into stdlib-js:develop Apr 20, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add ndarray/broadcast-scalar-like

3 participants

@headlessNode @stdlib-bot @kgryte